Require device trust for initial device registration endpoints#38451
Merged
Require device trust for initial device registration endpoints#38451
Conversation
Joerger
force-pushed
the
joerger/require-device-trust-for-add-mfa
branch
from
41d0871 to
0d87538
Compare
avatus
reviewed
Feb 21, 2024
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
Code looks fine but I'm not sure we want to disable first-time registration on web until another option is in place. Although, that isn't up to me I suppose! I don't feel comfortable approving as my context here is pretty light.
codingllama
reviewed
Feb 22, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Looks good. No product commentary on my part either.
Code looks fine but I'm not sure we want to disable first-time registration on web until another option is in place
@avatus note that, as this is written, enforcement is based on the global device trust mode, so that does alleviate the "breakage" somehow.
Joerger
force-pushed
the
joerger/require-device-trust-for-add-mfa
branch
from
9807a15 to
c61a22d
Compare
Joerger
force-pushed
the
joerger/require-device-trust-for-add-mfa
branch
from
52a2fac to
1846fcd
Compare
avatus
approved these changes
Feb 26, 2024
codingllama
approved these changes
Feb 26, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from fheinecke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: When device trust is required and MFA is optional, users will need to add their first MFA device from a trusted device.
Note: This this will make it impossible for a user to add their first MFA device from the WebUI, as device trust is not yet supported in the WebUI. They can instead add it with
tsh. It may also be worth adding device management to Teleport Connect. A fix for device trust in the WebUI may be developed soon - https://github.com/gravitational/teleport.e/issues/3236.