fix: Avoid tsh panic on Windows Server 2019#38444
Merged
codingllama merged 1 commit intomasterfrom Feb 21, 2024
Merged
Conversation
Contributor
Author
|
FYI @stevenGravy. |
Contributor
thanks! @tenaciousdlg |
Contributor
Author
|
Steven kindly tried out a test build, seems to be working fine. |
hugoShaka
approved these changes
Feb 20, 2024
rosstimothy
approved these changes
Feb 20, 2024
|
@codingllama See the table below for backport results.
|
This was referenced Feb 21, 2024
|
I have the same issue with tsh v.14.3.3 and 15.0.2. |
Member
|
@sergefedorow Could you try tsh v14.3.4 which shipped with this fixed? 15.0.3 is not out yet but it'll include the fix as well. |
|
@ravicious Unfortunately 14.3.4 does not work for me either. |
Member
|
Sorry, my bad, I looked at the release notes for 14.3.4 and I saw #36868 which was a fix for a similar problem. 14.3.7+ is going to include the fix, I imagine it'll be released later this or next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some Windows installs appear to contain a WebAuthn.dll without WebAuthNGetApiVersionNumber, which leads to a panic. This PR aims to fix that.
Error on Windows Server 2019
WebAuthNGetApiVersionNumber is a v1 procedure on WebAuthn.dll, so in its absence we disable WebAuthn support as well (as all bets are off in which other functions may or may not exist).
Changelog: Avoid tsh/WebAuthn.dll panic on Windows Server 2019