Add auto enrolling capability to EKS Discover flow

[AntonAM]

This PR adds ability to setup autoenrollment of EKS clusters in the Discover UI using discover configs.

Autoenrollment of EKS is very similar to autoenrollment of RDS databases, so it follows same pattern, even a bit simpler because we don't need to think about deploying DB services. I extracted shared components -SelfHostedAutoDiscoverDirections and AutoEnrollDialog.

Demo in action: https://www.loom.com/share/5e4e6bb2d6494338ad96cad7964dc711

Changelog: Add auto-enrolling capabilities to EKS discover flow in the web UI

[gzdunek]

Nit: the PR would be a bit simpler to review if extracting the shared components happened in a separate PR. Now it is difficult to distinguish between the moved code and the new one.

[gzdunek]

TBH I'd just keep move content of this function to the catch clause, we use it only in that place.
Also we have a logic that isn't use at all (cfg.setAttempt).

[AntonAM]

Changed ca14a4c

[AntonAM]

@gzdunek thanks for the review! Yeah, you're right, it would be better if I at least did a dedicated commit for extraction. (AutoEnrollDialog was correctly identified as moved, SelfHostedAutoDiscoverDirections file content was copied almost exactly as is, except for changing databases text reference to "resources")

[kimlisa]

did we ask kenny for advice (if yes ignore my comment)? my initial reaction is that it should be stacked on top

[kimlisa]

we should add a comment on what notifyAboutDelay means (i think skipDeployment made more sense tbh 🤷‍♀️ ). in the deployment section we let user know it'll take a few minutes, but since we are skipping deployment we have to show the note in the enrolling section

[AntonAM]

Added comment. EKS doesn't have service deployment but has same need to warn user. I think it's a general capability that we want to notify user that for auto discovery resources will take some time to appear. be00e9c

[kimlisa]

i'd leave it empty string if cloud, to make a point that that variable only applies to self-hosted

[AntonAM]

Done.

[kimlisa]

i'm not sure this is necessary, think you can just do this?

export const WithTraitsAutoDiscovery = () => (
  <MemoryRouter>
    <SetupAccess {...props}  agentMeta={...props.agentMeta, autoDiscovery= .....} />
  </MemoryRouter>
);

i wasn't sure if you knew, but this copy is a shallow copy, nested things dont get copied and you could be modifying the original

[AntonAM]

Yep, it's shallow copy, that's why we did it twice so we don't change original props. I didn't figure out syntax at first for the inline change (it needs extra braces agentMeta={{...props.agentMeta, autoDiscovery: {...} }} ), changed. 0fd4f00

[kimlisa]

i encourage a story :)

[AntonAM]

Done :) f117d5c

[kimlisa]

if auto discovering, does duplicated users/groups gets de-duplicated in the network call? i'd add a test for this

[AntonAM]

Yep it's deduplicated.

[kimlisa]

i'd add a test similar to what's being done in RDS

[AntonAM]

I'll add test (and for useUserTraits), but will do it in a separate PR, since it will take me some time and I just want to make sure EKS auto discovery is merged for 15.1 release

[kimlisa]

i think this is simple enough to just inline it like this:

   .post(cfg.getDiscoveryConfigUrl(clusterId), {
      name: req.name,
      discoveryGroup: req.discoveryGroup,
      aws: makeAwsMatchersReq(req.aws),
    })

[AntonAM]

Done.

[AntonAM]

@kimlisa I changed the toggles to be stacked on top of each other, will ask Kenny later.

[AntonAM]

@kimlisa @gzdunek I've addressed all feedback, PTAL

[public-teleport-github-review-bot]

@AntonAM See the table below for backport results.

Branch	Result
branch/v15	Create PR