Add EKS auto discovery for dynamic integration based fetchers.#38204
Merged
Add EKS auto discovery for dynamic integration based fetchers.#38204
Conversation
AntonAM
added
kubernetes-access
discovery
no-changelog
AntonAM
force-pushed
the
anton/eks-auto-enrollment
branch
3 times, most recently
from
f39b50e to
028d3dc
Compare
AntonAM
force-pushed
the
anton/eks-auto-enrollment
branch
from
028d3dc to
ec18d97
Compare
rosstimothy
reviewed
Feb 15, 2024
tigrato
reviewed
Feb 15, 2024
rosstimothy
reviewed
Feb 23, 2024
AntonAM
force-pushed
the
anton/eks-auto-enrollment
branch
from
726f690 to
736bd91
Compare
AntonAM
force-pushed
the
anton/eks-auto-enrollment
branch
from
736bd91 to
fff35c4
Compare
AntonAM
changed the base branch from
master
to
anton/awsoidc-grpc-enroll-eks-clusters
marcoandredinis
approved these changes
Feb 28, 2024
tigrato
reviewed
Feb 28, 2024
AntonAM
force-pushed
the
anton/awsoidc-grpc-enroll-eks-clusters
branch
4 times, most recently
from
c614736 to
9c3b91f
Compare
Base automatically changed from
anton/awsoidc-grpc-enroll-eks-clusters
to
master
February 28, 2024 19:46
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
This reverts commit 0eb3f4f1226239a5d4e768ebe9129535be318ccb.
AntonAM
force-pushed
the
anton/eks-auto-enrollment
branch
from
a682f97 to
960584e
Compare
tigrato
reviewed
Feb 28, 2024
tigrato
approved these changes
Feb 28, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from mdwn
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
Collaborator
|
/excludeflake * |
AntonAM
added a commit
that referenced
this pull request
Feb 29, 2024
* AWSOIDC: Move enrollment of EKS clusters to the gRPC service. * Fix after rebase. * Add EKS auto discovery for dynamic integration based fetchers. * Remove commented code. Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Remove unneeded code. Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> * Add missing godoc. * Initiate map with length. Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Fix typo in the interface name. * Introduce iam join method for EKS enrollment. * Correctly process DiscoveredEKSCluster in kube watcher. * Remove remaining CreateToken related code from Discovery service. * Change var initialization. Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Remove dev version detection for EKS enrollment. Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Revert "Introduce iam join method for EKS enrollment." This reverts commit 0eb3f4f1226239a5d4e768ebe9129535be318ccb. * Fix usage of a missing function. * Refactor cluster features to be a function. * Change discovery to use gRPC call for EKS enrollment. * Remove unused mock. * Correct a comment. * Remove token creation permission from Discovery service. * Fix after rebase. * Improve sorting clusters by region and integration. Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * Return and error if cluster features are missing. * Fix tests. --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
… (#38772) * AWSOIDC: Move enrollment of EKS clusters to the gRPC service. * Fix after rebase. * Add EKS auto discovery for dynamic integration based fetchers. * Remove commented code. * Remove unneeded code. * Add missing godoc. * Initiate map with length. * Fix typo in the interface name. * Introduce iam join method for EKS enrollment. * Correctly process DiscoveredEKSCluster in kube watcher. * Remove remaining CreateToken related code from Discovery service. * Change var initialization. * Remove dev version detection for EKS enrollment. * Revert "Introduce iam join method for EKS enrollment." This reverts commit 0eb3f4f1226239a5d4e768ebe9129535be318ccb. * Fix usage of a missing function. * Refactor cluster features to be a function. * Change discovery to use gRPC call for EKS enrollment. * Remove unused mock. * Correct a comment. * Remove token creation permission from Discovery service. * Fix after rebase. * Improve sorting clusters by region and integration. * Return and error if cluster features are missing. * Fix tests. --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dynamic kube watchers that use integration as means of authentication to AWS, it will be used for Discover UI EKS integration in auto-discovery mode.