Conversation
zmb3
commented
Feb 14, 2024
Collaborator
Author
There was a problem hiding this comment.
Open to suggestions for better ways to detect this.
We could check if bytes is empty, if p is the zero value, or look at some field other than name.
Contributor
There was a problem hiding this comment.
I bet there's plenty of things in the profile yaml that could make the profile unusable if wrong; do we want to catch them all, or is it just an advisory check here?
If it's the latter I think that checking the name should be enough.
espadolini
approved these changes
Feb 14, 2024
When unmarshaling the profile YAML, it's possible for the unmarshal to complete without error while not populating the profile struct, which leads to a panic. Fix the nil pointer dereference by unmarshaling into a Profile instead of a *Profile, and further improve the error message when this happens. Fixes #38188
zmb3
force-pushed
the
zmb3/tsh-panic-fix
branch
from
ac52c4d to
53fca97
Compare
Joerger
approved these changes
Feb 15, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from ibeckermayer
This was referenced Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unmarshaling the profile YAML, it's possible for the unmarshal to complete without error while not populating the profile struct, which leads to a panic.
Fix the nil pointer dereference by unmarshaling into a Profile instead of a *Profile, and further improve the error message when this happens.
Fixes #38188
Changelog: fix a potential panic in the
tsh statuscommand.