Fix Assist z-index so it doesn't hide the user dropdown when docked#38148
Merged
Fix Assist z-index so it doesn't hide the user dropdown when docked#38148
Conversation
zmb3
approved these changes
Feb 13, 2024
ravicious
approved these changes
Feb 13, 2024
| animation: forwards ${fadeIn} 0.3s ease-in-out; | ||
| background: rgba(0, 0, 0, 0.5); | ||
| z-index: 1000; | ||
| z-index: ${p => (p.docked ? 2 : 100)}; |
Member
There was a problem hiding this comment.
Long term we should start thinking of using some kind of a map for z-index levels so that we don't get lost in them. I remember briefly talking with Grzegorz about this when we ran into a similar problem in Connect (#20988 (comment)).
Member
Author
There was a problem hiding this comment.
Agreed. This could also not be positioned absolutely/fixed when docked, but I wanted a quick fix 😅
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
|
@ryanclark See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Assist is docked, it obstructs the user dropdown
Before:
After:
This changes the z-index to just 2 when docked, and 100 when not docked
changelog: Fix Assist obstructing the user dropdown menu when in docked mode