Merged
Conversation
This test writes sample data to a temporary file and then tries to parse it. In #34177 we disallowed reading the environment file from a symlink, but the Go utilities we use to create temp files end up using symlinks on macOS. Fix this by breaking out the core functionality such that it only requires an io.Reader instead of an os.File.
zmb3
added
the
no-changelog
jentfoo
approved these changes
Feb 9, 2024
rosstimothy
approved these changes
Feb 12, 2024
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Collaborator
Author
|
@ibeckermayer @jakule PTAL |
jakule
approved these changes
Feb 14, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from ibeckermayer
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test writes sample data to a temporary file and then tries to parse it. In #34177 we disallowed reading the environment file from a symlink, but the Go utilities we use to create temp files end up using symlinks on macOS.
Fix this by breaking out the core functionality such that it only requires an io.Reader instead of an os.File.