Improve handling of unrecognized documents in Connect#38015
Merged
Improve handling of unrecognized documents in Connect#38015
Conversation
ravicious
added
backport/branch/v13
no-changelog
gzdunek
approved these changes
Feb 9, 2024
Contributor
There was a problem hiding this comment.
Maybe we could use unknown instead of any?
Member
Author
There was a problem hiding this comment.
What's the difference in this case?
Contributor
There was a problem hiding this comment.
Not significant, since we only print the field.
But if it is any, a thing like unhandledCase.abc.def is allowed - if unknown it isn't, so the type is more strict.
I will leave it up to you.
Member
Author
There was a problem hiding this comment.
Ah, that makes total sense for a highly "generic" field such as unhandledCase. Changed any to unknown.
avatus
approved these changes
Feb 9, 2024
ravicious
force-pushed
the
r7s/unhandled-case
branch
from
7194a68 to
92a6e05
Compare
|
@ravicious See the table below for backport results.
|
This was referenced Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36730 made it so that Connect doesn't throw when it encounters an unknown document kind. This can typically happen when downgrading the app while your app_state.json contains documents from a newer version.
However,
getResourceUriwas still throwing and with "Unhandled case: [object Object]". This PR makes it so that we serialize the unhandled case to console and preventsgetResourceUrifrom throwing.