add preset field to SAMLIdPServiceProviderV1 spec#37968
Merged
flyinghermit merged 4 commits intomasterfrom Feb 9, 2024
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
r0mant
approved these changes
Feb 8, 2024
Collaborator
r0mant
left a comment
There was a problem hiding this comment.
lgtm with a couple of comments
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
|
The PR changelog entry failed validation: The changelog entry must start with a letter. |
espadolini
approved these changes
Feb 9, 2024
|
@flyinghermit See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
presetfield will be used to process custom configuration for specified service provider. The field can be empty in default state (which means a generic service provider type) but if a value is provided, we expect to be one of the supported one.A new package
samlsphas been added that defines a preset name for GCP. Subsequent name for other SAML apps, including their custom configuration values (if any) will go into this package.changelog: The
saml_idp_service_providerspec adds a newpresetfield that can be used to specify pre-built SAML service provider profile.