Skip to content

add preset field to SAMLIdPServiceProviderV1 spec#37968

Merged
flyinghermit merged 4 commits intomasterfrom
sshah/samlidp-preset-profile
Feb 9, 2024
Merged

add preset field to SAMLIdPServiceProviderV1 spec#37968
flyinghermit merged 4 commits intomasterfrom
sshah/samlidp-preset-profile

Conversation

@flyinghermit
Copy link
Copy Markdown
Contributor

@flyinghermit flyinghermit commented Feb 8, 2024

The preset field will be used to process custom configuration for specified service provider. The field can be empty in default state (which means a generic service provider type) but if a value is provided, we expect to be one of the supported one.

kind: saml_idp_service_provider
metadata:
  name: appname
spec:
  preset: gcp (or azure, gitlab etc)
  entity_id: https://samlsp-host

A new package samlsp has been added that defines a preset name for GCP. Subsequent name for other SAML apps, including their custom configuration values (if any) will go into this package.

changelog: The saml_idp_service_provider spec adds a new preset field that can be used to specify pre-built SAML service provider profile.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple of comments

Comment thread api/types/saml_idp_service_provider.go Outdated
Comment thread api/types/saml_idp_service_provider.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

The PR changelog entry failed validation: The changelog entry must start with a letter.

@flyinghermit flyinghermit added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@flyinghermit flyinghermit added this pull request to the merge queue Feb 9, 2024
Merged via the queue into master with commit 0cc7731 Feb 9, 2024
@flyinghermit flyinghermit deleted the sshah/samlidp-preset-profile branch February 9, 2024 14:54
@public-teleport-github-review-bot
Copy link
Copy Markdown

@flyinghermit See the table below for backport results.

Branch Result
branch/v15 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants