Skip to content

[v13] Fix message for idle desktop connection#37957

Merged
zmb3 merged 2 commits intobranch/v13from
bot/backport-37735-branch/v13
Feb 9, 2024
Merged

[v13] Fix message for idle desktop connection#37957
zmb3 merged 2 commits intobranch/v13from
bot/backport-37735-branch/v13

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Feb 8, 2024 •
edited by camscale
Loading

Backport #37735 to branch/v13

changelog: Improved error handling when idle desktop connections are terminated.

@zmb3
Fix message for idle desktop connection
6e0062c 
If a custom client idle message wasn't specified, then we wouldn't
send any message to the browser prior to closing the connection,
which resulted in a generic disconnect error.

Also fixes a leak in connection monitor tests.

Fixes #36822
Updates #18496
@zmb3 zmb3 enabled auto-merge February 9, 2024 19:53
@zmb3 zmb3 added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@zmb3 zmb3 added this pull request to the merge queue Feb 9, 2024
Merged via the queue into branch/v13 with commit 3a836f5 Feb 9, 2024
@zmb3 zmb3 deleted the bot/backport-37735-branch/v13 branch February 9, 2024 20:52
@camscale camscale mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@probakowski probakowski probakowski approved these changes

+1 more reviewer

@ibeckermayer ibeckermayer ibeckermayer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport desktop-access size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zmb3 @probakowski @ibeckermayer