Skip to content

Set the access request max duration to 14 days, add okta-requester role..#37947

Merged
mdwn merged 7 commits intomasterfrom
mike.wilson/max-duration-2-weeks
Feb 14, 2024
Merged

Set the access request max duration to 14 days, add okta-requester role..#37947
mdwn merged 7 commits intomasterfrom
mike.wilson/max-duration-2-weeks

Conversation

@mdwn
Copy link
Copy Markdown
Contributor

@mdwn mdwn commented Feb 8, 2024

The max duration for an access request is now 14 days. A new role called okta-requester has been introduced which takes advantage of this new, expanded access request in order to improve day one Okta operations and our dogfooding effort. This will allow users requesting Okta resources to request them for longer periods of time, allowing approvers more time to approve the given access requests.

changelog: The maximum duration for an access request is now 14 days, the okta-requester role has been added which takes advantage of this.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@mdwn mdwn force-pushed the mike.wilson/max-duration-2-weeks branch from e4491ed to d3b9d64 Compare February 8, 2024 20:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Comment thread lib/services/access_request.go Outdated
Comment thread lib/services/access_request.go Outdated
Comment thread lib/services/access_request.go Outdated
Copy link
Copy Markdown
Contributor

@Tener Tener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with Zac's points. Independently, are there any docs worth updating?

@smallinsky smallinsky self-requested a review February 12, 2024 14:04
Comment thread lib/services/presets.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-q9hpw79ko-goteleport.vercel.app/docs/ver/preview

@mdwn mdwn force-pushed the mike.wilson/max-duration-2-weeks branch from 34f1cad to 3c7c42a Compare February 13, 2024 20:38
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-9l6a7gh48-goteleport.vercel.app/docs/ver/preview

Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few comments.

Comment thread constants.go Outdated
Comment thread lib/services/presets.go Outdated
Comment thread lib/services/presets.go Outdated
Comment thread lib/services/presets.go Outdated
Comment thread lib/services/presets.go Outdated
Comment thread lib/services/presets.go Outdated
Comment thread lib/services/presets.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-g98ngydni-goteleport.vercel.app/docs/ver/preview

Mike Wilson added 5 commits February 14, 2024 10:44
@mdwn mdwn force-pushed the mike.wilson/max-duration-2-weeks branch from f2a5c6b to b5b0c57 Compare February 14, 2024 16:37
@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-1ozcxbt0v-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-iqpdj6p5h-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-cl0cmpd0m-goteleport.vercel.app/docs/ver/preview

@mdwn mdwn added this pull request to the merge queue Feb 14, 2024
Merged via the queue into master with commit bb58d86 Feb 14, 2024
@mdwn mdwn deleted the mike.wilson/max-duration-2-weeks branch February 14, 2024 18:07
@public-teleport-github-review-bot
Copy link
Copy Markdown

@mdwn See the table below for backport results.

Branch Result
branch/v15 Create PR

@mdwn mdwn changed the title Set the access request max duration to 14 days. Set the access request max duration to 14 days, add okta-requester role.. Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants