Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts#37929
Conversation
a71c1d0 to
8564106
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
🤖 Vercel preview here: https://docs-g2qjl321m-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-6jkx1fnxy-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-2kffbfy3f-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-fpnxy7lqe-goteleport.vercel.app/docs/ver/preview |
The table there actually seems to be correct, think the mixup only happened here. |
hugoShaka
left a comment
There was a problem hiding this comment.
Do we want to put an "Action Required for opsgenie plugin users" or something in the changelog? So they can check if they got the right version and annotation.
Also, is this flagged as a security fix? From what I understand, the plugin allowed users to escalate even if they were not on-call for the correct service.
The schedules checked for auto approval should still be the ones from |
|
🤖 Vercel preview here: https://docs-badfsh1on-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-692jxnxhf-goteleport.vercel.app/docs/ver/preview |
|
@EdwardDowling See the table below for backport results.
|
Closes #37318
The Opsgenie plugin was mixing up the two annotations it checks causing alerts to be created when
/scheduleswas set even thoughnotify-services was notchangelog: Fixes Opsgenie plugin creating alerts based on incorrect annotation. Action Required for Opsgenie plugin users