Skip to content

Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts#37929

Merged
EdwardDowling merged 6 commits intomasterfrom
edwarddowling/opsgenie-plugin-fix
Feb 12, 2024
Merged

Fix opsgenie plugin to use correct annotation to determine whether or not to create alerts#37929
EdwardDowling merged 6 commits intomasterfrom
edwarddowling/opsgenie-plugin-fix

Conversation

@EdwardDowling
Copy link
Copy Markdown
Contributor

@EdwardDowling EdwardDowling commented Feb 8, 2024

Closes #37318
The Opsgenie plugin was mixing up the two annotations it checks causing alerts to be created when /schedules was set even though notify-services was not

changelog: Fixes Opsgenie plugin creating alerts based on incorrect annotation. Action Required for Opsgenie plugin users

@EdwardDowling EdwardDowling marked this pull request as ready for review February 8, 2024 16:43
@github-actions github-actions Bot added documentation rfd Request for Discussion size/sm labels Feb 8, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

🤖 Vercel preview here: https://docs-g2qjl321m-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

🤖 Vercel preview here: https://docs-6jkx1fnxy-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 8, 2024

🤖 Vercel preview here: https://docs-2kffbfy3f-goteleport.vercel.app/docs/ver/preview

Comment thread integrations/access/opsgenie/client.go Outdated
Comment thread integrations/access/opsgenie/client.go Outdated
Comment thread integrations/access/opsgenie/client.go
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2024

🤖 Vercel preview here: https://docs-fpnxy7lqe-goteleport.vercel.app/docs/ver/preview

Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardDowling
Copy link
Copy Markdown
Contributor Author

We should also edit the table here: https://docs-fpnxy7lqe-goteleport.vercel.app/docs/access-controls/access-requests/access-request-configuration/#plugins-that-support-request-annotations

The table there actually seems to be correct, think the mixup only happened here.

Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put an "Action Required for opsgenie plugin users" or something in the changelog? So they can check if they got the right version and annotation.

Also, is this flagged as a security fix? From what I understand, the plugin allowed users to escalate even if they were not on-call for the correct service.

@EdwardDowling
Copy link
Copy Markdown
Contributor Author

Do we want to put an "Action Required for opsgenie plugin users" or something in the changelog? So they can check if they got the right version and annotation.

Also, is this flagged as a security fix? From what I understand, the plugin allowed users to escalate even if they were not on-call for the correct service.

The schedules checked for auto approval should still be the ones from /schedules the issues was that these were also used as the ones to notify.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-badfsh1on-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Vercel preview here: https://docs-692jxnxhf-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling added this pull request to the merge queue Feb 12, 2024
Merged via the queue into master with commit 3455f3b Feb 12, 2024
@EdwardDowling EdwardDowling deleted the edwarddowling/opsgenie-plugin-fix branch February 12, 2024 17:55
@public-teleport-github-review-bot
Copy link
Copy Markdown

@EdwardDowling See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation rfd Request for Discussion size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpsGenie Alerts created for access request without any teleport.dev/notify-services annotation

5 participants