[v15] Read the bearer token over websocket endpoints instead of query parameter#37915
Closed
lxea wants to merge 17 commits intobranch/v15from
Closed
[v15] Read the bearer token over websocket endpoints instead of query parameter#37915lxea wants to merge 17 commits intobranch/v15from
lxea wants to merge 17 commits intobranch/v15from
Conversation
use the request context, not session Dont pass websocket by context lint resolve some comments Add TestWSAuthenticateRequest Close ws in handler deprecation notices, doc resolve comments resolve comments give a longer read/write deadline dont set write deadline, ws endpoints never did before and it breaks things convert frontend to use ws access token Resolove comments, move to using an explicit state fix ci reset read deadline prettier
…cket` (#37699) * Converts `AuthenticatedWebSocket` into drop-in replacement for `WebSocket` that automatically goes through Teleport's custom authentication process before facilitating any caller-defined communication. This also reverts previous-`WebSocket` users to their original state (sans the code for passing the bearer token in the query string), swapping in `AuthenticatedWebSocket` in place of `WebSocket`.
github-actions
Bot
requested review from
ibeckermayer,
jakule,
r0mant,
rosstimothy,
ryanclark and
zmb3
Contributor
Author
Tested it with node connection, this applied cleanly so should be okay, working on the v14/13 versions |
zmb3
requested changes
Feb 8, 2024
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Playback of recorded desktop sessions appears broken on master.
ibeckermayer
approved these changes
Feb 9, 2024
public-teleport-github-review-bot
Bot
removed request for
jakule,
rosstimothy and
ryanclark
lxea
force-pushed
the
bot/backport-37520-branch/v15
branch
from
ca39cba to
883e3d2
Compare
This was mistakenly left out of #37520. This commit also refactors `WithClusterAuthWebSocket` slightly for easier comprehension, and updates the vite config to facilitate the new websocket endpoints in development mode.
Contributor
|
Closed in favor of #38032 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37520 to branch/v15
changelog: Read bearer token via websocket on websocket endpoints