[v15] Fix wasm-pack builds#37856
Merged
zmb3 merged 2 commits intobranch/v15from Feb 7, 2024
Merged
Conversation
wasm-pack will do this at build time if the target is not available, but by baking it into the image we avoid having to do it during each build.
And make sure that we always install the version from the lockfile, which prevents wasm-pack from failing with --mode=no-install.
zmb3
added
the
no-changelog
codingllama
approved these changes
Feb 7, 2024
tigrato
approved these changes
Feb 7, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from rosstimothy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37851 to branch/v15