Skip to content

Update Prettier to 3.2.5#37837

Merged
gzdunek merged 2 commits intomasterfrom
gzdunek/prettier-3
Feb 8, 2024
Merged

Update Prettier to 3.2.5#37837
gzdunek merged 2 commits intomasterfrom
gzdunek/prettier-3

Conversation

@gzdunek
Copy link
Copy Markdown
Contributor

@gzdunek gzdunek commented Feb 7, 2024

The current Prettier version is quite old and doesn't support newer TypeScript features such as satisfies, so we should update it.

@gzdunek gzdunek added backport/branch/v13 no-changelog Indicates that a PR does not require a changelog entry labels Feb 7, 2024
@github-actions github-actions Bot requested review from kimlisa and rudream February 7, 2024 09:43
Copy link
Copy Markdown
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👦👍🖥️

Attempt<void>
>(makeEmptyAttempt());
const [startPtyProcessAttempt, setStartPtyProcessAttempt] =
useState<Attempt<void>>(makeEmptyAttempt());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better.

? SearchResultDatabase['resource']
: Kind extends 'kube'
? SearchResultKube['resource']
: never;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@gzdunek gzdunek added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 103f351 Feb 8, 2024
@gzdunek gzdunek deleted the gzdunek/prettier-3 branch February 8, 2024 10:50
@public-teleport-github-review-bot
Copy link
Copy Markdown

@gzdunek See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Failed
branch/v15 Failed

gzdunek added a commit that referenced this pull request Feb 8, 2024
(cherry picked from commit 103f351)
gzdunek added a commit that referenced this pull request Feb 8, 2024
(cherry picked from commit 103f351)
gzdunek added a commit that referenced this pull request Feb 8, 2024
(cherry picked from commit 103f351)
github-merge-queue Bot pushed a commit that referenced this pull request Feb 8, 2024
github-merge-queue Bot pushed a commit that referenced this pull request Feb 8, 2024
github-merge-queue Bot pushed a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants