Conversation
Starting with an empty shell we can add to.
nklaassen
commented
Feb 14, 2024
strideynet
reviewed
Feb 16, 2024
ravicious
reviewed
Feb 16, 2024
ravicious
reviewed
Feb 21, 2024
ravicious
force-pushed
the
rfd/0163-vnet
branch
from
d1c29dd to
1c70d28
Compare
ravicious
reviewed
Feb 26, 2024
nklaassen
commented
Feb 27, 2024
gzdunek
reviewed
Feb 27, 2024
ravicious
reviewed
Mar 1, 2024
nklaassen
commented
Mar 2, 2024
zmb3
reviewed
Mar 29, 2024
sdrosdzol
reviewed
Apr 2, 2024
sdrosdzol
left a comment
sdrosdzol
left a comment
There was a problem hiding this comment.
I have reviewed the RFD. Below are my two comments on certain security considerations
ravicious
reviewed
Apr 2, 2024
rosstimothy
reviewed
Apr 24, 2024
Comment on lines
+147
to
+148
| When the DNS server receives a query for any subdomain of those suffixes, it | ||
| will search the cluster for an app with a matching `public_addr`. |
Contributor
There was a problem hiding this comment.
Will searching be done via fuzzy search or a predicate expression?
Contributor
Author
There was a problem hiding this comment.
All searches will be done with predicate expression searches, exact matches on the public_addr with a prefix match on the resource.spec.uri
zmb3
approved these changes
Apr 26, 2024
rosstimothy
approved these changes
Apr 30, 2024
public-teleport-github-review-bot
Bot
removed request for
sdrosdzol and
tigrato
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered version