Conversation
github-actions
Bot
added
size/sm
tsh
rosstimothy
reviewed
Feb 4, 2024
This deprecates `tsh kube sessions` in favor of a command that can be used to list all types of active sessions. Closes #19152
zmb3
force-pushed
the
zmb3/tsh-sessions-ls
branch
from
c42abe1 to
a80ac93
Compare
rosstimothy
approved these changes
Feb 6, 2024
| filtered := slices.DeleteFunc(sessions, func(st types.SessionTracker) bool { | ||
| return !slices.Contains(kinds, st.GetSessionKind()) | ||
| }) | ||
| sort.Slice(filtered, func(i, j int) bool { |
Contributor
There was a problem hiding this comment.
Not sure it if matters given how small the filtered slice is going to be, but, will slices.SortFunc be any more performant than sort.Slices?
Suggested change
| sort.Slice(filtered, func(i, j int) bool { | |
| slices.SortFunc(filtered, func(i, j int) int { |
probakowski
approved these changes
Feb 8, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from camscale
This was referenced Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates
tsh kube sessionsin favor of a command that can be used to list all types of active sessions.Closes #19152
Changelog: add a tsh sessions ls command to list active sessions.