[v13] Fix app redirection loop on browser's incognito mode and 3rd party cookie block#37698
Merged
kimlisa merged 1 commit intobranch/v13from Feb 12, 2024
Merged
Conversation
bl-nero
approved these changes
Feb 6, 2024
r0mant
approved these changes
Feb 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #30321 to branch/v13
manual because some changes in newer branches were not backported to branch/v13 notably the
withCustomCorsmiddleware wrapper for app handlers (which basically moves the serveHTTP logic into its own function (withCustomCors)tested with and without fix, with chrome and incognito chrome (cookies are blocked by default in incognito):
i also tested with the legacy
AppLaunchercomponent to make sure the previous handlers still workedChangelog: Fixed app redirection loop on browser's incognito mode and 3rd party cookie block