[v13] Fix list all access list members/reviews pagination.#37675
Merged
mdwn merged 3 commits intobranch/v13from Feb 2, 2024
Merged
[v13] Fix list all access list members/reviews pagination.#37675mdwn merged 3 commits intobranch/v13from
mdwn merged 3 commits intobranch/v13from
Conversation
Two things were happening that was preventing the cache of access list members from initializing if the number of members was greater than the default page size of 200: 1. The incorrect page token was being used in the ListAllAccessListMembers call. 2. The pagination key for listing all of these members was incorrect due to the use of sub-prefixes. Both issues have been corrected. The ListAllAccessListMembers call in the access list service now uses its own custom pagination logic.
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
espadolini
approved these changes
Feb 1, 2024
Contributor
|
It looks like there are a few conflicts that still need to be resolved |
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
rosstimothy
approved these changes
Feb 2, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from zmb3
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37593 to branch/v13.
Note: This backport was manual due to a conflict in lib/local/access_list_test.go. I had to pull in the newAccessListService helper function and remove tests that were for functionality that was not backported to v13.
changelog: Fixed cache init issue with access list members/reviews.