Skip to content

integrations/operator: Add openSSH and openSSHEICE servers#37651

Merged
hugoShaka merged 5 commits intomasterfrom
hugo/operator-add-server-kinds
Feb 20, 2024
Merged

integrations/operator: Add openSSH and openSSHEICE servers#37651
hugoShaka merged 5 commits intomasterfrom
hugo/operator-add-server-kinds

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka commented Feb 1, 2024

Fixes: #36839

This PR adds OpenSSH and OpenSSHEICE support to the operator through two new resources:

  • TeleportOpensshServer
  • TeleportOpensshEICEServer

Notes about the 1 resource vs many resources for the subkinds:

  • teleport, openssh, and openssh-aws-eice subkinds are backed by the same resource
  • the operator must not manage the teleport subkind
  • there is no Kubernetes-friendly way to pass a subkind, putting it in the spec would break the unmarshalling

changelog: Add OpensshServer and OpensshEICEServer support in the operator

@hugoShaka hugoShaka force-pushed the hugo/operator-add-server-kinds branch from 3d179b9 to ed03338 Compare February 5, 2024 16:03
@hugoShaka hugoShaka marked this pull request as ready for review February 5, 2024 16:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@public-teleport-github-review-bot
Copy link
Copy Markdown

@hugoShaka - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 5, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Comment thread integrations/operator/controllers/resources/global.go Outdated
Comment thread integrations/operator/controllers/resources/openssheiceserverv2_controller.go Outdated
Comment thread integrations/operator/controllers/resources/openssheiceserverv2_controller.go Outdated
@hugoShaka hugoShaka force-pushed the hugo/operator-add-server-kinds branch from 813f4a7 to 961d0c5 Compare February 6, 2024 16:50
spec:
description: OpenSSHServer resource definition v2 from Teleport
properties:
addr:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this property mandatory or should we leave it to teleport?
This is a situation where validation hooks would be great

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think teleport should reject an invalid value and we should keep the CRD validation to the minimum: enforcing a sane data structure.

@hugoShaka hugoShaka force-pushed the hugo/operator-add-server-kinds branch from 961d0c5 to b06fd8f Compare February 20, 2024 22:51
@hugoShaka hugoShaka enabled auto-merge February 20, 2024 22:54
@hugoShaka hugoShaka added this pull request to the merge queue Feb 20, 2024
Merged via the queue into master with commit 288f87a Feb 20, 2024
@hugoShaka hugoShaka deleted the hugo/operator-add-server-kinds branch February 20, 2024 23:24
@public-teleport-github-review-bot
Copy link
Copy Markdown

@hugoShaka See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support declaring agentless nodes via the operator

4 participants