Skip to content

[v15] Display "UNKNOWN" for unsupported connections #37591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gzdunek merged 2 commits into from
Jan 31, 2024
Merged

[v15] Display "UNKNOWN" for unsupported connections #37591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f158ac
Display "UNKNOWN" for unsupported connections
gzdunek Jan 31, 2024
1afc2b4
Merge branch 'branch/v15' into bot/backport-37584-branch/v15
gzdunek Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions web/packages/teleterm/src/ui/TopBar/Connections/ConnectionsFilterableList/ConnectionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,18 @@ function getKindName(connection: ExtendedTrackedConnection): string {
if (isDatabaseUri(connection.targetUri)) {
return 'DB';
}
return '';
return 'UNKNOWN';
case 'connection.server':
return 'SSH';
case 'connection.kube':
return 'KUBE';
default:
return '';
// The default branch is triggered when the state read from the disk
// contains a connection not supported by the given Connect version.
//
// For example, the user can open an app connection in Connect v15
// and then downgrade to a version that doesn't support apps.
// That connection should be shown as 'UNKNOWN' in the connection list.
return 'UNKNOWN';
}
}