Adds --locked to all cargo builds and to wasm-pack build#37576
Closed
ibeckermayer wants to merge 1 commit intomasterfrom
Closed
Adds --locked to all cargo builds and to wasm-pack build#37576ibeckermayer wants to merge 1 commit intomasterfrom
--locked to all cargo builds and to wasm-pack build#37576ibeckermayer wants to merge 1 commit intomasterfrom
Conversation
ibeckermayer
added
no-changelog
ibeckermayer
force-pushed
the
isaiah/frozen
branch
from
902c9bc to
6336c6e
Compare
ibeckermayer
force-pushed
the
isaiah/frozen
branch
from
6336c6e to
70f3712
Compare
ibeckermayer
changed the title
--locked to all cargo builds and to wasm-pack build
Collaborator
|
Addressed in #37851 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enforces that the Cargo.lock is already up-to-date (meaning semver compatible with the relevant Cargo.toml(s)) whenever we
cargo build. This is desirable in CI, where we want to use Cargo.lock exactly, without it ever being updated unexpectedly. All updates should be explicitly handled offline.Should not be merged until