Reuse tunnel resolvers instead of creating one per connection attempt#37566
Merged
rosstimothy merged 1 commit intomasterfrom Feb 2, 2024
Merged
Reuse tunnel resolvers instead of creating one per connection attempt#37566rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
rosstimothy
force-pushed
the
tross/process_resolver
branch
from
7089543 to
8749ef3
Compare
rosstimothy
changed the title
rosstimothy
force-pushed
the
tross/process_resolver
branch
2 times, most recently
from
46d6684 to
b121c99
Compare
The `CachingResolver` is backed by a `FnCache` but does not expose a way to close the underlying cache. This leads to memory leaks as captured in #37025. Instead of modifying the resolver to allow explicit cleanup to occur, the resolvers were refactored to be created once per process instead of per connenction attempt to the cluster. Since the cluster address is read from the config file, it won't be changed for the duration of the process which allows us to safely use a single resolver. The one potential downside to this approach is the cache may return possibly stale errors during an outage until the entry is TTLed. Fixes #37025
rosstimothy
force-pushed
the
tross/process_resolver
branch
from
b121c99 to
eed9af4
Compare
strideynet
approved these changes
Jan 31, 2024
zmb3
approved these changes
Feb 2, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Feb 2, 2024
…#37566) The `CachingResolver` is backed by a `FnCache` but does not expose a way to close the underlying cache. This leads to memory leaks as captured in #37025. Instead of modifying the resolver to allow explicit cleanup to occur, the resolvers were refactored to be created once per process instead of per connenction attempt to the cluster. Since the cluster address is read from the config file, it won't be changed for the duration of the process which allows us to safely use a single resolver. The one potential downside to this approach is the cache may return possibly stale errors during an outage until the entry is TTLed. Fixes #37025
rosstimothy
added a commit
that referenced
this pull request
Feb 2, 2024
…#37566) The `CachingResolver` is backed by a `FnCache` but does not expose a way to close the underlying cache. This leads to memory leaks as captured in #37025. Instead of modifying the resolver to allow explicit cleanup to occur, the resolvers were refactored to be created once per process instead of per connenction attempt to the cluster. Since the cluster address is read from the config file, it won't be changed for the duration of the process which allows us to safely use a single resolver. The one potential downside to this approach is the cache may return possibly stale errors during an outage until the entry is TTLed. Fixes #37025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
…#37566) (#37723) The `CachingResolver` is backed by a `FnCache` but does not expose a way to close the underlying cache. This leads to memory leaks as captured in #37025. Instead of modifying the resolver to allow explicit cleanup to occur, the resolvers were refactored to be created once per process instead of per connenction attempt to the cluster. Since the cluster address is read from the config file, it won't be changed for the duration of the process which allows us to safely use a single resolver. The one potential downside to this approach is the cache may return possibly stale errors during an outage until the entry is TTLed. Fixes #37025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
…#37566) (#37719) The `CachingResolver` is backed by a `FnCache` but does not expose a way to close the underlying cache. This leads to memory leaks as captured in #37025. Instead of modifying the resolver to allow explicit cleanup to occur, the resolvers were refactored to be created once per process instead of per connenction attempt to the cluster. Since the cluster address is read from the config file, it won't be changed for the duration of the process which allows us to safely use a single resolver. The one potential downside to this approach is the cache may return possibly stale errors during an outage until the entry is TTLed. Fixes #37025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CachingResolveris backed by aFnCachebut does not expose a way to close the underlying cache. This leads to memory leaks as captured in #37025. Instead of modifying the resolver to allow explicit cleanup to occur, the resolvers were refactored to be created once per process instead of per connection attempt to the cluster. Since the cluster address is read from the config file, it won't be changed for the duration of the process which allows us to safely use a single resolver. The one potential downside to this approach is the cache may return possibly stale errors during an outage until the entry is TTLed.Fixes #37025
changelog: Fix memory leak in tbot caused by never closing reverse tunnel address resolvers