[v13] feat!: Rewrite FIDO2 device interactions to be non-concurrent#37539
Merged
codingllama merged 1 commit intobranch/v13from Jan 30, 2024
Merged
[v13] feat!: Rewrite FIDO2 device interactions to be non-concurrent#37539codingllama merged 1 commit intobranch/v13from
codingllama merged 1 commit intobranch/v13from
Conversation
* Bump go-libfido2 to 399e6dce025f0fae1e47088e4912e113512240cb bump * Add the IsFIDO2 and Close functions to FIDODevice * Rewrite FIDO2 device interactions as single-threaded * test: Wait for device goroutines on tests * test: Drop "metered" tests * test: Adjust tests according to behavioral changes * nit: Invert u2f flag to fido2 * Reintroduce Info retries * nit: Update old comments * Delete unused code * test: Fix minor lint issues * Set the libfido2 device timeout * Appease linter * Revert "test: Wait for device goroutines on tests" This reverts commit 2f87127. * nit: Function declaration indent * Document that openedDevices.devices doesn't change length after assigned * Log the retry interval * Bump go-libfido2 to v1.5.3-teleport.1
github-actions
Bot
requested review from
GavinFrazar,
hugoShaka and
rosstimothy
Contributor
Author
|
Clean cherry-pick, except for a go.mod conflict in unrelated modules. |
hugoShaka
approved these changes
Jan 30, 2024
GavinFrazar
approved these changes
Jan 30, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from rosstimothy
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37181 to branch/v13.
Changelog: tsh FIDO2 backend re-written for improved responsiveness and reliability.