[v13] Fix last good identity not being used by tbot if token is not configured#37448
Merged
strideynet merged 1 commit intobranch/v13from Feb 1, 2024
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: The changelog entry must start with a letter. |
justinas
approved these changes
Jan 30, 2024
ryanclark
approved these changes
Feb 1, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from smallinsky
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug only impacts the v13 series of releases as it looks like my v14 refactor which simplified much of this logic already resolved this bug :D
Closes #37434
changelog: tbot now correctly uses the last good persisted identity if
--join-tokenhas not been specified.