Skip to content

helm: make proxies replicable when usign an ingress #37430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugoShaka merged 1 commit into from
Jan 29, 2024
Merged

helm: make proxies replicable when usign an ingress #37430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/pages/reference/helm-reference/teleport-cluster.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,8 @@ is not supported with multiple replicas.
### For proxy pods

Proxy pods need to be provided a certificate to be replicated (via either
`tls.existingSecretName` or `highAvailability.certManager`).
`tls.existingSecretName` or `highAvailability.certManager`) or be exposed
via an ingress (`ingress.enabled`).
If proxy pods are replicable, they will default to 2 replicas,
even if `highAvailability.replicaCount` is 1. To force a single proxy replica,
set `proxy.highAvailability.replicaCount: 1`.
Expand Down
2 changes: 1 addition & 1 deletion examples/chart/teleport-cluster/templates/proxy/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- $proxy := mustMergeOverwrite (mustDeepCopy .Values) .Values.proxy -}}
{{- $replicable := or $proxy.highAvailability.certManager.enabled $proxy.tls.existingSecretName -}}
{{- $replicable := or $proxy.highAvailability.certManager.enabled $proxy.tls.existingSecretName $proxy.ingress.enabled -}}
{{- $projectedServiceAccountToken := semverCompare ">=1.20.0-0" .Capabilities.KubeVersion.Version }}
# Deployment is {{ if not $replicable }}not {{end}}replicable
{{- if and $proxy.highAvailability.certManager.enabled $proxy.tls.existingSecretName }}
Expand Down
12 changes: 12 additions & 0 deletions examples/chart/teleport-cluster/tests/proxy_deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,18 @@ tests:
path: spec.replicas
value: 1

- it: should have multiple replicas by default when an ingress is terminating TLS
template: proxy/deployment.yaml
set:
clusterName: helm-lint.example.com
proxyListenerMode: multiplex
ingress:
enabled: true
asserts:
- equal:
path: spec.replicas
value: 2

- it: should set affinity when set in values
template: proxy/deployment.yaml
set:
Expand Down
3 changes: 2 additions & 1 deletion examples/chart/teleport-cluster/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,8 @@ azure:
# is not supported with multiple replicas.
# For proxy pods:
# Proxy pods need to be provided a certificate to be replicated (either via
# `tls.existingSecretName` or via `highAvailability.certManager`).
# `tls.existingSecretName` or via `highAvailability.certManager`) or be exposed
# via an ingress (`ingress.enabled`).
# If proxy pods are replicable, they will default to 2 replicas,
# even if `highAvailability.replicaCount` is 1. To force a single proxy replica,
# set `proxy.highAvailability.replicaCount: 1`.
Expand Down