Skip to content

Fix gRPC logging interceptor in Connect#37410

Merged
ravicious merged 1 commit intomasterfrom
r7s/grpc-logs
Jan 29, 2024
Merged

Fix gRPC logging interceptor in Connect#37410
ravicious merged 1 commit intomasterfrom
r7s/grpc-logs

Conversation

@ravicious
Copy link
Copy Markdown
Member

@ravicious ravicious commented Jan 29, 2024

The old middleware was dependent on the client implementation, which was changed during the move to the new protobuf library (#36921).

The middleware itself is no longer necessary – the new client accepts interceptors through the interceptors option.

@ravicious ravicious added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels Jan 29, 2024
@github-actions github-actions Bot requested a review from kimlisa January 29, 2024 12:18
@ravicious ravicious removed the request for review from kimlisa January 29, 2024 12:27
@ravicious ravicious enabled auto-merge January 29, 2024 12:43
@ravicious ravicious changed the title Fix gRPC logging interceptors in Connect Fix gRPC logging interceptor in Connect Jan 29, 2024
@ravicious ravicious added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit 46c1cab Jan 29, 2024
@ravicious ravicious deleted the r7s/grpc-logs branch January 29, 2024 13:28
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ravicious See the table below for backport results.

Branch Result
branch/v15 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-for-v15 no-changelog Indicates that a PR does not require a changelog entry size/sm ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants