Don't send new TDP messages to old agents#37393
Merged
Conversation
With Teleport 15 we introduced a new message to sync the state of modifier keys (caps lock, num lock, etc.) Teleport 14 desktop agents don't support this message, so we must not send it to them or it will corrupt the TDP stream. Fixes #37381
zmb3
added
no-changelog
ibeckermayer
approved these changes
Jan 28, 2024
probakowski
approved these changes
Jan 29, 2024
zmb3
added a commit
that referenced
this pull request
Feb 6, 2024
In #37393 we added logic to ensure that we don't send a newer TDP message to a v14 client that doesn't support it. For v16 proxies and up, v14 agents are no longer supported, so this code is no longer necessary.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
In #37393 we added logic to ensure that we don't send a newer TDP message to a v14 client that doesn't support it. For v16 proxies and up, v14 agents are no longer supported, so this code is no longer necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Teleport 15 we introduced a new message to sync the state of modifier keys (caps lock, num lock, etc.)
Teleport 14 desktop agents don't support this message, so we must not send it to them or it will corrupt the TDP stream.
Fixes #37381