Use cache for listing app sessions#37378
Merged
rosstimothy merged 1 commit intomasterfrom Jan 27, 2024
Merged
Conversation
ListAppSessions was never added to the `auth.Cache` interface or implemented by `cache.Cache` which means all session listing was using the backend as the data source. This could cause backend throttling if the number of sessions was large enough.
fspmarshall
approved these changes
Jan 26, 2024
fspmarshall
approved these changes
Jan 26, 2024
zmb3
approved these changes
Jan 27, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from AntonAM
|
@rosstimothy See the table below for backport results.
|
This was referenced Jan 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListAppSessions was never added to the
auth.Cacheinterface or implemented bycache.Cachewhich means all session listing was using the backend as the data source. This could cause backend throttling if the number of sessions was large enough.changelog: Prevent backend throttling caused by a large number of app sessions