do not log stream close error for EOF#37240
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
8b24f74 to
5a86449
Compare
|
I guess However, I will backport to v13/v14 anyway |
|
@GavinFrazar See the table below for backport results.
|
This PR eliminates a fake error log when closing file session uploads.
I noticed that every time I disconnected from a database, I would see this in the agent logs:
Note the inconsistency between "failed to close stream" and "session upload completed".
In fact, what happened is that the upload completed and the upstream auth server closed the stream, but when we check the error returned from
stream.Close(ctx), it's actually wrapped in aRemoteErrorwrapper created by the api client's grpc stream interceptor.Fixed by using
errors.Isinstead, sinceRemoteErrorimplementsUnwrap() error.