[v15] Make tctl bots add prompt for MFA just once#37224
Merged
Joerger merged 2 commits intobranch/v15from Jan 25, 2024
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
no-changelog
hugoShaka
approved these changes
Jan 24, 2024
GavinFrazar
approved these changes
Jan 24, 2024
public-teleport-github-review-bot
Bot
removed request for
EdwardDowling and
avatus
Joerger
changed the base branch from
joerger/v15/reuse-mfa-tctl-users-add
to
branch/v15
Joerger
force-pushed
the
joerger/v15/reuse-mfa-tctl-bots-add
branch
from
54e6e4f to
393afda
Compare
* Reuse MFA for tctl bots add. * Fix MFA required check for admin role. * Remove broken auth preference check; Fix IsMFARequiredCheck for built in Admin role. * Check for nil MFA response in MFA retry logic. * Refactor MFA ceremony to return a custom error when MFA is not required. * Fix TestAdminActionMFA unit tests. * Fix unit test.
Joerger
force-pushed
the
joerger/v15/reuse-mfa-tctl-bots-add
branch
from
393afda to
fbcd038
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #37121 to branch/v15
Depends on #37198