Skip to content

[v14] Reduce spammy reconciler messages. #37142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdwn merged 1 commit into from
Jan 24, 2024
Merged

[v14] Reduce spammy reconciler messages. #37142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/services/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,12 @@ func NewReconciler[T Reconciled](cfg ReconcilerConfig[T]) (*Reconciler[T], error
}
return &Reconciler[T]{
cfg: cfg,
log: cfg.Log,
// We do a WithFields here to force this into a *logrus.Entry, which has the ability to
// log at the Trace level. If we were to change this in ReconcilerConfig, we'd have to
// refactor existing code to use *logrus.Entry instead of logrus.FieldLogger, and with
// the eventual change to slog, it seems easier to do this for now until this can be
// changed to slog.
log: cfg.Log.WithFields(nil),
}, nil
}

Expand All @@ -95,7 +100,7 @@ func NewReconciler[T Reconciled](cfg ReconcilerConfig[T]) (*Reconciler[T], error
// to enable dynamically registered resources.
type Reconciler[T Reconciled] struct {
cfg ReconcilerConfig[T]
log logrus.FieldLogger
log *logrus.Entry
}

// Reconcile reconciles currently registered resources with new resources and
Expand Down Expand Up @@ -190,6 +195,6 @@ func (r *Reconciler[T]) processNewResource(ctx context.Context, currentResources
return nil
}

r.log.Debugf("%v %v is already registered.", kind, name)
r.log.Tracef("%v %v is already registered.", kind, name)
return nil
}