Conversation
|
Does this also prevent the cluster dropdown from extending beyond the bottom of the page? If you look real hard in the screenshot that I attached in #37014 I was scrolled all the way to the end of the list and was unable to see the last entry. |
Yes, the screenshot above has 500 entries in it. it will not grow larger than the screenshot height and can scroll to the bottom of the list |
There was a problem hiding this comment.
i'd write a story for this shared component and write states for empty, 1, couple, and a few hundred.
There was a problem hiding this comment.
matches the gap with the other filter dropdown
| top: 240px !important; | |
| top: 236px !important; |
There was a problem hiding this comment.
just as an fyi when you come back to tackle this, it still gets pushed up when a error banner renders
There was a problem hiding this comment.
i think we can take this out so it isn't calculating when there is no filter?
let filteredOptions = options
if (clusterFilter) {
filteredOptions = options
.filter(cluster =>
cluster.label
.toLowerCase()
.includes(clusterFilter.toLowerCase())
)
}bba2118 to
13ff0c1
Compare
|
Force pushed because my branch got out of whack. added a story and fixed the padding |
Fixes #37014
This PR adds a search field filter to the cluster dropdown. Some choices we made with design
If you want to test it locally, update the
loadClustersfunction to something like this