Merged
Conversation
The reconciler will now log the "already registered" messages at the trace level instead of at debug, which should reduce how spammy this log entry is.
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
hugoShaka
approved these changes
Jan 23, 2024
rosstimothy
reviewed
Jan 23, 2024
| type Reconciler[T Reconciled] struct { | ||
| cfg ReconcilerConfig[T] | ||
| log logrus.FieldLogger | ||
| log *logrus.Entry |
Contributor
There was a problem hiding this comment.
Another option would be to use logrus.Ext1FieldLogger which is an extension of FieldLogger that adds the trace methods.
Contributor
Author
There was a problem hiding this comment.
I thought about that, but the comment for it says:
// Ext1FieldLogger (the first extension to FieldLogger) is superfluous, it is
// here for consistancy. Do not use. Use Logger or Entry instead.
So I elected to use Entry here.
Collaborator
There was a problem hiding this comment.
Should we just remove the log entry entirely? I can't really think of any case when we will need to know this.
It's pretty standard that a reconciler sees existing resources.
AntonAM
approved these changes
Jan 23, 2024
public-teleport-github-review-bot
Bot
removed request for
GavinFrazar and
r0mant
mdwn
deleted the
mike.wilson/reduce-reconciler-already-registered-to-trace
branch
This was referenced Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reconciler will now log the "already registered" messages at the trace level instead of at debug, which should reduce how spammy this log entry is.
changelog: Reduced logging level for services that reconcile resources.