Conversation
nklaassen
added
no-changelog
zmb3
approved these changes
Jan 23, 2024
rosstimothy
approved these changes
Jan 23, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from capnspacehook
|
@nklaassen See the table below for backport results.
|
nklaassen
added a commit
that referenced
this pull request
Oct 30, 2024
Backport #37068 to branch/v14
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Backport #37068 to branch/v14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got broken in a dependency update #35610 where we stopped passing
0and started passing a pointer to0for theNewerNoncurrentVersionsfield. This fails validation, the value must be unset or a positive integer. We don't actually want any noncurrent versions around (we don't use them) and in my testing, leaving it unset behaves like you'd expect if it was set to 0.fixes #37062
no changelog because the bug never made it into a release