Add [disabled] Bots list view#36845
Merged
michellescripts merged 1 commit intomasterfrom Feb 1, 2024
Merged
Conversation
michellescripts
force-pushed
the
michelle/bots
branch
2 times, most recently
from
46837fb to
3618f23
Compare
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
michellescripts
requested review from
kimlisa and
ryanclark
and removed request for
klizhentas and
r0mant
michellescripts
force-pushed
the
michelle/bots
branch
from
3618f23 to
9aecea0
Compare
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
michellescripts
force-pushed
the
michelle/bots
branch
from
9aecea0 to
c0d0a09
Compare
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ryanclark
reviewed
Jan 19, 2024
michellescripts
force-pushed
the
michelle/bots
branch
4 times, most recently
from
8712ece to
f6b3119
Compare
michellescripts
force-pushed
the
michelle/bots
branch
from
f6b3119 to
6c353f0
Compare
kimlisa
previously approved these changes
Jan 19, 2024
ryanclark
reviewed
Jan 22, 2024
Contributor
Author
|
@kimlisa @ryanclark temporarily converting back to draft status. This design wasn't intended to see the light of day (rather just used to speed up the integration), but we're pivoting and using DataTable as the MVP. Let me clean this up, and I'll reopen/re-request! |
michellescripts
force-pushed
the
michelle/bots
branch
4 times, most recently
from
46f7b2e to
eef9c7a
Compare
kimlisa
approved these changes
Jan 29, 2024
michellescripts
force-pushed
the
michelle/bots
branch
5 times, most recently
from
9d15376 to
5b1ed7d
Compare
Collaborator
|
/excludeflake * |
michellescripts
force-pushed
the
michelle/bots
branch
from
5b1ed7d to
b08c75d
Compare
michellescripts
force-pushed
the
michelle/bots
branch
from
b08c75d to
f33b15e
Compare
- in original data table view
michellescripts
force-pushed
the
michelle/bots
branch
from
f33b15e to
7671f0f
Compare
michellescripts
added a commit
that referenced
this pull request
Feb 12, 2024
- in original data table view
michellescripts
added a commit
that referenced
this pull request
Feb 13, 2024
- in original data table view
michellescripts
added a commit
that referenced
this pull request
Feb 16, 2024
- in original data table view
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Add endpoint to get bots by name (#37412) * Add endpoint to get bots by name * Lint * Fix test method's name Co-authored-by: Noah Stride <noah.stride@goteleport.com> --------- Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Backend supporting changes for Bot creation flow (#37348) * Add bot ui labels and github join token * Use strings.HasPrefix instead of includes * Add `ssh` to label * Add bot join token endpoint * Lint * Fix comment typo Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com> * Fix comment typo Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com> * Improve webUIFlowLabelKey comment --------- Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com> * add bots UI, disabled (#36845) - in original data table view * Add Bot + GitHub Actions SSH UI Flow (#37443) * add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Update copy and minor style change --------- Co-authored-by: Michelle Bergquist <michelle.bergquist@goteleport.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> * add bot edit-role flow (#37828) * add bot edit-role flow * only send masked/updated fields * Add GitHub Actions bot view (#37852) * add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Add bot type by label * Add bot view... * Show view gh actions yaml only for gh bots * Use existing pattern for operations * Add story and missing license * Fix typos Co-authored-by: Michelle Bergquist <11967646+michellescripts@users.noreply.github.com> --------- Co-authored-by: Michelle Bergquist <michelle.bergquist@goteleport.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> Co-authored-by: Michelle Bergquist <11967646+michellescripts@users.noreply.github.com> * Add buttons to download and copy to clipboard content to `TextEditor` (#37333) * Add editor buttons * Set icon size * Move downloadObject to OSS * remove unused test-id * Use values from theme * Fix buttons positioning * Convert jsx files to tsx * Use const instead of var * Add z-index to buttons * Add license * Improvements to Bot resource (additional validation and label propagation) (#38013) * PRevent creating bots with an empty string role * Propagate labels to Bot user and vice versa * Extract slice declaration for nonPropagatedLabels * Fixed web tests relying on empty string roles * Use "set" instead of slice for nonPropagatedLabels * Make testing of empty string handling more thorough * add role assertions to create * Appease linter as to want/got order --------- Co-authored-by: Michelle Bergquist <michelle.bergquist@goteleport.com> * Add bot permissions and turn on feature (#37943) * Fix makeBot labels (#38176) --------- Co-authored-by: matheus <matheus.battirola@goteleport.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new access management menu item: Bots and the ability to delete a bot from the list. Currently, it is disabled (false in Features) until we integrate the create workflows. Until then, "enroll" will also be disabled.
This PR uses the old DataTable styles rather than the new Resources look/feel. This expedites the integrations across the team; a follow-up PR will start to tackle the new style. We are also only showing the name, roles and options button at this time.
Pagination for bots is MVP - we will fetch all the bots in the API and return them to the UI for pagination. This is due to a limitation of our Bot Service, which needs to fetch ListUsers to get bots. The team is aware of the pitfalls of this approach and will be revisiting this in the future. I left a comment on the Bot service list method.
Supports #34260
e-sibling: https://github.com/gravitational/teleport.e/pull/3294