Fix an issue AWS Redshift auto-provisioned user not deleted in drop mode#36828
Merged
Fix an issue AWS Redshift auto-provisioned user not deleted in drop mode#36828
Conversation
greedy52
added
database-access
greedy52
commented
Jan 17, 2024
Comment on lines
+6
to
+7
| IF EXISTS (SELECT user_name FROM stv_sessions WHERE user_name = CONCAT('IAM:', username)) THEN | ||
| RAISE EXCEPTION 'TP000: User has active connections'; |
Contributor
Author
There was a problem hiding this comment.
Copied from:
teleport/lib/srv/db/postgres/sql/redshift-deactivate-user.sql
Lines 7 to 11 in 8815257
Note the bug happens because pg_stat_activity is sometimes delayed so that the procedure will RAISE NOTICE 'User has active connections';. However, RAISE NOTICE does not trigger an error in our database engine with Redshift.
r0mant
approved these changes
Jan 18, 2024
| -- Only drop if the user doesn't have other active sessions. | ||
| IF EXISTS (SELECT usename FROM pg_stat_activity WHERE usename = username) THEN | ||
| RAISE NOTICE 'User has active connections'; | ||
| IF EXISTS (SELECT user_name FROM stv_sessions WHERE user_name = CONCAT('IAM:', username)) THEN |
Collaborator
There was a problem hiding this comment.
Nit: Maybe include a link to https://docs.aws.amazon.com/redshift/latest/dg/r_STV_SESSIONS.html that explains what this table is? I had to look it up.
smallinsky
approved these changes
Jan 22, 2024
public-teleport-github-review-bot
Bot
removed request for
flyinghermit and
gabrielcorado
greedy52
force-pushed
the
STeve/36708/fix
branch
from
6105a56 to
1d778d1
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36708
changelog: Fix an issue AWS Redshift auto-provisioned user not deleted in drop mode