Fix AccessList proto 0 time mapping to epoch#36810
Merged
Conversation
hugoShaka
added
bug
terraform-provider
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
hugoShaka
changed the title
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
mdwn
approved these changes
Jan 17, 2024
tigrato
approved these changes
Jan 18, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from camscale
marcoandredinis
approved these changes
Jan 18, 2024
|
@hugoShaka See the table below for backport results.
|
This was referenced Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs does exactly like https://github.com/gravitational/teleport/pull/32135/files but for AccessList NextAuditDate: ensuring proto zero time is converted to go's zero time and vice versa.
This issue happens if an accesslist is created from a protobuf struct without NextAuditDate set, which ios the case for the TF provider.
changelog: Fix Terraform provider creating AccessLists with next audit date set to Epoch