[v15] Increment connect_to_node_attempts_total during dial attempts#36740
Merged
rosstimothy merged 1 commit intobranch/v15from Jan 19, 2024
Merged
[v15] Increment connect_to_node_attempts_total during dial attempts#36740rosstimothy merged 1 commit intobranch/v15from
rosstimothy merged 1 commit intobranch/v15from
Conversation
During refactoring performed in #18370 the counter was moved but never used outside of registration. This restores incrementing the counter for dial attempts and improves error reporting in traces in the router.
strideynet
approved these changes
Jan 16, 2024
Contributor
Author
|
ping @zmb3 |
AntonAM
approved these changes
Jan 19, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from zmb3
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36633 to branch/v15
changelog: Ensure connect_to_node_attempts_total is always incremented when dialing hosts