Explicitly close FIDO2 devices#36635
Closed
codingllama wants to merge 7 commits intomasterfrom
Closed
Conversation
Contributor
Author
|
I've shipped this build to a few customers and it seems to have improved assertion speed and reduced the occurrence of "tx errors". |
Contributor
Author
|
I'll take a look at the test failures later. |
capnspacehook
approved these changes
Jan 13, 2024
codingllama
force-pushed
the
codingllama/fido2-tx-error
branch
from
b88fd88 to
cf5f228
Compare
codingllama
force-pushed
the
codingllama/fido2-tx-error
branch
from
cf5f228 to
bdce290
Compare
Contributor
Author
|
I've just pushed a few additional commits: c8dbe9b, bcb13c4 and bdce290. The first is self-explanatory. bcb13c4 fixes a panic that happens occasionally. bdce290 ensures fobs aren't left blinking forever in some particularly bad failures. It does mean that we expect a touch to happen within 30s, but I expect that to be a reasonable time interval. |
Contributor
Author
|
As before, I'll create a dev build with those changes and send for some folks to try it out. |
zmb3
approved these changes
Jan 16, 2024
Contributor
Author
|
Closed in favor of #37181. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep FIDO2 devices open for the duration of the interactions and explicitly close them at the end.
Requires gravitational/go-libfido2#15.
#36640
Changelog: Improve speed and reliability of FIDO2 devices