[v13] fix: Verify MFA device locks during authentication#36627
Merged
codingllama merged 2 commits intobranch/v13from Jan 15, 2024
Merged
[v13] fix: Verify MFA device locks during authentication#36627codingllama merged 2 commits intobranch/v13from
codingllama merged 2 commits intobranch/v13from
Conversation
* Test authn and password change with a locked user * Verify MFA device locks during authentication * Configure a LockWatcher in the passwordSuite setup * Appease linter
Contributor
Author
|
Branches v13 (and likely v12) differ significantly on AuthenticateUser when compared to newer branches. The first cherry-pick is pretty much clean, minus some minor variable/method name changes here and there. I've kept changes exclusive to branch/v13 on 184a682 for easier reviews. Sadly, these make v13 (and v12 to follow) become something that is in-between master and their old form. The alternative would be to backport whatever caused the deviations in the first place, which I elected not to do now. |
jentfoo
approved these changes
Jan 12, 2024
tigrato
approved these changes
Jan 12, 2024
rosstimothy
approved these changes
Jan 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36471 to branch/v13.
Fix an oversight on authentication where locked MFA devices could still be used. Applies to password changes as well.
https://github.com/gravitational/security-findings/issues/81
Changelog: Verify MFA device locks during user authentication