Prevent ConnectionMonitor leaks#36621
Merged
rosstimothy merged 1 commit intomasterfrom Jan 13, 2024
Merged
Conversation
The context used to create the connection monitor for app sessions was never canceled which left the connection monitor running until the certificate expired, the user was locked, or the idle timeout was enforced. By using the correct context and canceling appropriately the monitor is terminated as soon as the app session has concluded.
tigrato
approved these changes
Jan 12, 2024
zmb3
approved these changes
Jan 13, 2024
|
@rosstimothy See the table below for backport results.
|
This was referenced Jan 13, 2024
rosstimothy
added a commit
that referenced
this pull request
Jan 13, 2024
The context used to create the connection monitor for app sessions was never canceled which left the connection monitor running until the certificate expired, the user was locked, or the idle timeout was enforced. By using the correct context and canceling appropriately the monitor is terminated as soon as the app session has concluded.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
The context used to create the connection monitor for app sessions was never canceled which left the connection monitor running until the certificate expired, the user was locked, or the idle timeout was enforced. By using the correct context and canceling appropriately the monitor is terminated as soon as the app session has concluded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context used to create the connection monitor for app sessions was never canceled which left the connection monitor running until the certificate expired, the user was locked, or the idle timeout was enforced. By using the correct context and canceling appropriately the monitor is terminated as soon as the app session has concluded.
Partially addresses #36541.
changelog: Prevent a goroutine leak caused by app sessions not cleaning up resources properly