Fix routing to public addresses#36617
Merged
rosstimothy merged 1 commit intomasterfrom Jan 12, 2024
Merged
Conversation
gzdunek
approved these changes
Jan 12, 2024
rosstimothy
force-pushed
the
tross/fix_public_addr_routing
branch
from
47b08c6 to
4121b81
Compare
avatus
approved these changes
Jan 12, 2024
public-teleport-github-review-bot
Bot
removed request for
espadolini and
r0mant
rosstimothy
force-pushed
the
tross/fix_public_addr_routing
branch
2 times, most recently
from
65c12b5 to
42dbbf5
Compare
#36584 allowed routing to work for public addresses, however it used GetPublicAddr to retrieve the public address. types.Server can have multiple public addresses though which means routing was only ever considering the first public address defined. This updates the routing logic to use GetPublicAddrs so they are all considered.
rosstimothy
force-pushed
the
tross/fix_public_addr_routing
branch
from
42dbbf5 to
5da7f40
Compare
espadolini
approved these changes
Jan 12, 2024
|
@rosstimothy See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#36584 allowed routing to work for public addresses, however it used GetPublicAddr to retrieve the public address. types.Server can have multiple public addresses though which means routing was only ever considering the first public address defined. This updates the routing logic to use GetPublicAddrs so they are all considered.
Changelog: Fixed routing to nodes by their public addresses