[v14] Add dynamic/ prefix to server info labels (#36219)#36595
Merged
atburke merged 1 commit intobranch/v14from Jan 11, 2024
Merged
[v14] Add dynamic/ prefix to server info labels (#36219)#36595atburke merged 1 commit intobranch/v14from
atburke merged 1 commit intobranch/v14from
Conversation
This change: - Adds the dynamic/ prefix to labels from a server_info resource created with tctl - Forbids labels with the dynamic/ prefix form being used in deny rules for new roles. Existing roles will generate warnings in tctl as well as a cluster alert.
github-actions
Bot
requested review from
fspmarshall,
nklaassen and
rosstimothy
rosstimothy
approved these changes
Jan 11, 2024
r0mant
approved these changes
Jan 11, 2024
public-teleport-github-review-bot
Bot
removed request for
fspmarshall and
nklaassen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36219 to branch/v14
Changelog: Forbid labels prefixed with dynamic/ from being used in deny rules