Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic token providers in kubeconfig used by the proxy #3655

Merged
merged 4 commits into from
May 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -548,9 +548,6 @@ const (
// EnvUserProfile is the home directory environment variable on Windows.
EnvUserProfile = "USERPROFILE"

// KubeServiceAddr is an address for kubernetes endpoint service
KubeServiceAddr = "kubernetes.default.svc.cluster.local:443"

// KubeCAPath is a hardcode of mounted CA inside every pod of K8s
KubeCAPath = "/var/run/secrets/kubernetes.io/serviceaccount/ca.crt"

Expand Down
103 changes: 103 additions & 0 deletions lib/kube/proxy/auth.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
package proxy

import (
"crypto/tls"
"fmt"
"io/ioutil"
"net"
"net/http"
"net/url"
"os"

"github.com/gravitational/teleport"
kubeutils "github.com/gravitational/teleport/lib/kube/utils"
"github.com/gravitational/trace"
log "github.com/sirupsen/logrus"
"k8s.io/client-go/rest"
"k8s.io/client-go/transport"

// Load kubeconfig auth plugins for gcp and azure.
// Without this, users can't provide a kubeconfig using those.
//
// Note: we don't want to load _all_ plugins. This is a balance between
// support for popular hosting providers and minimizing attack surface.
_ "k8s.io/client-go/plugin/pkg/client/auth/azure"
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
)

// kubeCreds contain authentication-related fields from kubeconfig.
type kubeCreds struct {
// tlsConfig contains (m)TLS configuration.
tlsConfig *tls.Config
// transportConfig contains HTTPS-related configuration.
// Note: use wrapTransport method if working with http.RoundTrippers.
transportConfig *transport.Config
// targetAddr is a kubernetes API address.
targetAddr string
}

func getKubeCreds(kubeconfigPath string) (*kubeCreds, error) {
var cfg *rest.Config
// no kubeconfig is set, assume auth server is running in the cluster
if kubeconfigPath == "" {
caPEM, err := ioutil.ReadFile(teleport.KubeCAPath)
if err != nil {
return nil, trace.BadParameter(`auth server assumed that it is
running in a kubernetes cluster, but %v mounted in pods could not be read: %v,
set kubeconfig_file if auth server is running outside of the cluster`, teleport.KubeCAPath, err)
}

cfg, err = kubeutils.GetKubeConfig(os.Getenv(teleport.EnvKubeConfig))
if err != nil {
return nil, trace.BadParameter(`auth server assumed that it is
running in a kubernetes cluster, but could not init in-cluster kubernetes client: %v`, err)
}
cfg.CAData = caPEM
} else {
log.Debugf("Reading configuration from kubeconfig file %v.", kubeconfigPath)

var err error
cfg, err = kubeutils.GetKubeConfig(kubeconfigPath)
if err != nil {
return nil, trace.Wrap(err)
}
}

targetAddr, err := parseKubeHost(cfg.Host)
if err != nil {
return nil, trace.Wrap(err, "failed to parse kubernetes host")
}
tlsConfig, err := rest.TLSConfigFor(cfg)
if err != nil {
return nil, trace.Wrap(err, "failed to generate TLS config from kubeconfig")
}
transportConfig, err := cfg.TransportConfig()
if err != nil {
return nil, trace.Wrap(err, "failed to generate transport config from kubeconfig")
}

return &kubeCreds{
tlsConfig: tlsConfig,
transportConfig: transportConfig,
targetAddr: targetAddr,
}, nil
}

// parseKubeHost parses and formats kubernetes hostname
// to host:port format, if no port it set,
// it assumes default HTTPS port
func parseKubeHost(host string) (string, error) {
u, err := url.Parse(host)
if err != nil {
return "", trace.Wrap(err, "failed to parse kubernetes host")
}
if _, _, err := net.SplitHostPort(u.Host); err != nil {
// add default HTTPS port
return fmt.Sprintf("%v:443", u.Host), nil
}
return u.Host, nil
}

func (c *kubeCreds) wrapTransport(rt http.RoundTripper) (http.RoundTripper, error) {
return transport.HTTPWrappersForConfig(c.transportConfig, rt)
}
Loading