Skip to content

Fix mfa challenge is empty error#36483

Merged
Joerger merged 1 commit intomasterfrom
joerger/fix-mfa-prompt-no-challenge
Jan 10, 2024
Merged

Fix mfa challenge is empty error#36483
Joerger merged 1 commit intomasterfrom
joerger/fix-mfa-prompt-no-challenge

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Jan 9, 2024

Fix #36482 by restoring behavior of empty mfa challenges resulting in a no-op prompt.

This bug was caused by my refactors in #34087, which was not backported.

@github-actions github-actions Bot requested review from avatus and lxea January 9, 2024 21:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger added this pull request to the merge queue Jan 10, 2024
Merged via the queue into master with commit 0fe5d45 Jan 10, 2024
@Joerger Joerger deleted the joerger/fix-mfa-prompt-no-challenge branch January 10, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when no MFA device is registered - mfa challenge is empty

3 participants