Skip to content

docs: Add SAML service provider with entity id and acs url#36467

Merged
flyinghermit merged 6 commits intomasterfrom
sshah/samlidp-docs
Jan 23, 2024
Merged

docs: Add SAML service provider with entity id and acs url#36467
flyinghermit merged 6 commits intomasterfrom
sshah/samlidp-docs

Conversation

@flyinghermit
Copy link
Copy Markdown
Contributor

@flyinghermit flyinghermit commented Jan 9, 2024

Add service provider with entity id and acs url. Make entity descriptor configuration optional.

Also shuffles the steps as explained below.

Previous:

1. Configure role
2. Download Teleport metadata and upload to Service Provider
3. Add Service Provider to Teleport
4. Test

I think these steps require user to move back and forth, first start with web browser, then tctl and then back to web browser. I think moving step 3 as 1 would enable working with tctl once and then configure everything in browser. The first step Configure role is now moved to prerequisites as optional step. Referencing preset editor isn't bad for a quickstart and users would create dedicated role for production.

So now the steps are:

Prerequisites:
...
- Configure role

Steps:
1. Add Service Provider to Teleport
2. Download Teleport metadata and upload to Service Provider
3. Test

@flyinghermit flyinghermit requested review from mdwn and r0mant January 9, 2024 19:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@flyinghermit flyinghermit added the no-changelog Indicates that a PR does not require a changelog entry label Jan 9, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

🤖 Vercel preview here: https://docs-ax9j3ii1z-goteleport.vercel.app/docs/ver/preview

zmb3
zmb3 reviewed Jan 9, 2024
View reviewed changes
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
@flyinghermit
Copy link
Copy Markdown
Contributor Author

flyinghermit commented Jan 9, 2024 •
edited
Loading

Good to review Note to reviewer, testing with samltest.id is broken currently and will be resolved with #36057

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

🤖 Vercel preview here: https://docs-ml73qr5g3-goteleport.vercel.app/docs/ver/preview

mdwn
mdwn approved these changes Jan 12, 2024
View reviewed changes
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
nklaassen
nklaassen reviewed Jan 15, 2024
View reviewed changes
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
@flyinghermit
review comments:
946f3ed 
- copy edits
- use add-role-to-user.mdx to reference role update
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 15, 2024

🤖 Vercel preview here: https://docs-3z3g9oyff-goteleport.vercel.app/docs/ver/preview

@flyinghermit
Copy link
Copy Markdown
Contributor Author

flyinghermit commented Jan 16, 2024

Friendly ping.

@flyinghermit
Copy link
Copy Markdown
Contributor Author

flyinghermit commented Jan 19, 2024

Friendly ping @r0mant @ptgott @nklaassen @zmb3

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2024

🤖 Vercel preview here: https://docs-8lmje7vua-goteleport.vercel.app/docs/ver/preview

ptgott
ptgott approved these changes Jan 22, 2024
View reviewed changes
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
Comment thread docs/pages/access-controls/idps/saml-guide.mdx
Comment thread docs/pages/access-controls/idps/saml-guide.mdx Outdated
@flyinghermit
copy edits:
7193225 
- use lower case for service provider
- use generic service provider name instead of directly referencing samltest.id
- update test saml application copy
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 23, 2024

🤖 Vercel preview here: https://docs-aj5bgas6p-goteleport.vercel.app/docs/ver/preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 23, 2024

🤖 Vercel preview here: https://docs-mteqg3qwy-goteleport.vercel.app/docs/ver/preview

@flyinghermit flyinghermit added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 9eac64c Jan 23, 2024
@flyinghermit flyinghermit deleted the sshah/samlidp-docs branch January 23, 2024 01:13
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Jan 23, 2024

@flyinghermit See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR

This was referenced Jan 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptgott ptgott ptgott approved these changes

@nklaassen nklaassen Awaiting requested review from nklaassen

@zmb3 zmb3 Awaiting requested review from zmb3

+1 more reviewer

@mdwn mdwn mdwn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flyinghermit @mdwn @zmb3 @nklaassen @ptgott