Skip to content

Update docs for assume start time on access requests#36401

Merged
EdwardDowling merged 3 commits intomasterfrom
edwarddowling/future-assume-role-doc
Jan 9, 2024
Merged

Update docs for assume start time on access requests#36401
EdwardDowling merged 3 commits intomasterfrom
edwarddowling/future-assume-role-doc

Conversation

@EdwardDowling
Copy link
Copy Markdown
Contributor

@EdwardDowling EdwardDowling commented Jan 8, 2024

Add more details to assume start time docs for access requests as suggested in this comment

@EdwardDowling EdwardDowling mentioned this pull request Jan 8, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions github-actions Bot requested a review from zmb3 January 8, 2024 14:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2024

🤖 Vercel preview here: https://docs-egke1zqnc-goteleport.vercel.app/docs/ver/preview

zmb3
zmb3 reviewed Jan 8, 2024
View reviewed changes
Comment thread docs/pages/access-controls/access-requests/access-request-configuration.mdx Outdated
r0mant
r0mant approved these changes Jan 9, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with Zac's suggestion

@EdwardDowling @zmb3
Update docs/pages/access-controls/access-requests/access-request-conf…
989fada 
…iguration.mdx

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@EdwardDowling EdwardDowling requested a review from zmb3 January 9, 2024 10:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

🤖 Vercel preview here: https://docs-jj8gdazs1-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling added the no-changelog Indicates that a PR does not require a changelog entry label Jan 9, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2024

🤖 Vercel preview here: https://docs-ktcmgzw06-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling added this pull request to the merge queue Jan 9, 2024
Merged via the queue into master with commit 01a62eb Jan 9, 2024
@EdwardDowling EdwardDowling deleted the edwarddowling/future-assume-role-doc branch January 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0mant r0mant r0mant approved these changes

@ptgott ptgott ptgott approved these changes

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees

No one assigned

Labels

documentation no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EdwardDowling @r0mant @zmb3 @ptgott