Ensure that login time is set for app sessions#36365
Merged
Conversation
fspmarshall
approved these changes
Jan 6, 2024
tigrato
approved these changes
Jan 6, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from ibeckermayer
Not all code paths populate the login_time field of an app session. Ensure that it is set, which will produce better audit events and aid in debugging.
zmb3
force-pushed
the
zmb3/app-session-login-time
branch
from
40853e1 to
58eb424
Compare
This was referenced Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all code paths populate the login_time field of an app session. Ensure that it is set, which will produce better audit events and aid in debugging.
changelog: Ensure that the login time is populated for app sessions.