fallback to upstream when sessions are missing from cache#36364
Merged
fspmarshall merged 2 commits intomasterfrom Jan 8, 2024
Merged
fallback to upstream when sessions are missing from cache#36364fspmarshall merged 2 commits intomasterfrom
fspmarshall merged 2 commits intomasterfrom
Conversation
zmb3
approved these changes
Jan 5, 2024
fspmarshall
force-pushed
the
fspmarshall/session-fallback
branch
from
0265c29 to
ef49082
Compare
espadolini
approved these changes
Jan 7, 2024
public-teleport-github-review-bot
Bot
removed request for
capnspacehook and
programmerq
|
@fspmarshall See the table below for backport results.
|
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds upstream fallbacks for the direct lookup methods of the
WebSessionfamily of types. Intended to mitigate spurious access denied errors caused by failing session lookups. Use of this pattern is well-established for other critical resources such asUser, and is helpful in mitigating the effect of cache bugs and racy lookups.changelog: Fixed an issue where bad cache state could cause spurious access denied errors during app access.